refactor(web-ui): extract flow chat scroll stability helpers - #1822
Merged
Conversation
- move viewport reservation types and calculations into a dedicated module - keep VirtualMessageList compatible with React Fast Refresh - update focused tests to import the extracted helpers directly - preserve existing scroll stabilization behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VirtualMessageList.tsx.Fixes #
Type and Areas
Type:
Refactor
Areas:
Web UI, Flow Chat, virtualized message list
Motivation / Impact
VirtualMessageList.tsxexported several non-component helper functions so they could be tested directly. This triggered eightreact-refresh/only-export-componentswarnings and made the component module incompatible with React Fast Refresh expectations.The helpers now live in a dedicated pure logic module. This is a behavior-preserving refactor with no direct user-facing change.
Verification
pnpm run lint:web— passed with 0 warnings and 0 errorspnpm run type-check:web— passedpnpm --dir src/web-ui run test:run src/flow_chat/components/modern/VirtualMessageList.session-boundary.test.tsx src/flow_chat/components/modern/FlowChatViewportCoordinator.test.ts src/flow_chat/tool-cards/useToolCardHeightContract.test.tsx src/flow_chat/tool-cards/TodoWriteDisplay.test.tsx— 4 files and 38 tests passedgit diff --check— passedReviewer Notes
This change only relocates existing reservation and scroll-stability calculations.
VirtualMessageListand its tests consume the same functions through the newflowChatScrollStability.tsmodule.No user-facing strings, locale resources, or public contracts were changed.
Checklist